[libcxx-commits] [PATCH] D97538: [libcxx] [test] Ifdef out tests that rely on perms::none on directories for triggering errors

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

@ldionne - TL;DR: Nobody has so far come up with a reliable crossplatform way of making those tests work under sudo. For windows, there's a special directory with suitable characteristics that work for some tests. (If it turns out the special dir doesn't exist or doesn't behave as we need it to, we use `TEST_UNSUPPORTED()` to bail out of that particular test - maybe such an approach could be used to waive failures when run under sudo, too? That's a separate effort anyway.) This patch now ifdefs out the remaining few cases where the special dir couldn't be used (e.g. where the test requires changing permissions back and forth during the test).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97538/new/

https://reviews.llvm.org/D97538