[libcxx-commits] [PATCH] D100728: Add a missing debug assertion in <list>

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/include/list:2093
 void
 list<_Tp, _Alloc>::splice(const_iterator __p, list& __c, const_iterator __f, const_iterator __l)
 {
----------------
curdeius wrote:
> Hmm, would it make sense to add as well a debug check that `__p` is not in range `[__f, __l)` (that's a UB)?
Perhaps, but I don't think we have any such assertions at the moment, and that //would// need a new test; so I'm deferring it to a separate PR (and probably a separate programmer :))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100728/new/

https://reviews.llvm.org/D100728