[libcxx-commits] [PATCH] D100728: Add a missing debug assertion in <list>

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius accepted this revision.
curdeius added a comment.
This revision is now accepted and ready to land.

LGTM if this will get tested by https://reviews.llvm.org/D100595.



================
Comment at: libcxx/include/list:2093
 void
 list<_Tp, _Alloc>::splice(const_iterator __p, list& __c, const_iterator __f, const_iterator __l)
 {
----------------
Hmm, would it make sense to add as well a debug check that `__p` is not in range `[__f, __l)` (that's a UB)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100728/new/

https://reviews.llvm.org/D100728