[libcxx-commits] [PATCH] D100682: [libc++][nfc] Move incrementable_traits and indirectly_readable_traits into separate headers.

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb accepted this revision.
cjdb added a comment.

LGTM with changes applied.



================
Comment at: libcxx/include/__iterator/incrementable_traits.h:59
+
+// TODO(cjdb): add iter_difference_t once iterator_traits is cleaned up.
+
----------------
Please delete this now that we have the design doc.


================
Comment at: libcxx/include/concepts:443-454
+template<class _Tp>
+using __with_reference = _Tp&;
+
+template<class _Tp>
+concept __referenceable = requires {
+  typename __with_reference<_Tp>;
+};
----------------
Please put these in `__iterator/concepts.h`. They shouldn't be in `<concepts>`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100682/new/

https://reviews.llvm.org/D100682