[libcxx-commits] [PATCH] D100682: [libc++][nfc] Move incrementable_traits and indirectly_readable_traits into separate headers.

Fri Apr 16 13:34:42 PDT 2021

zoecarver added inline comments.

================
Comment at: libcxx/include/__iterator/readable_traits.h:16
+
+#if !defined(_LIBCPP_HAS_NO_RANGES)
+
----------------
ldionne wrote:
> zoecarver wrote:
> > ldionne wrote:
> > > It would make sense to hoist that out of this file and into `<iterator>`. Same for incrementable traits.
> > Eh, I don't know. I'd be OK doing that and adding an `#error` here if it's not defined. I'd kind of like all our headers to always be includable, though. 
> Ok, this is non-blocking anyway, feel free to leave as-is. Actually when we only support compilers that support concepts, this will become `#if C++ >= 20`, which we should leave in this header. So it makes sense to keep.
SGTM.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100682/new/

https://reviews.llvm.org/D100682