[libcxx-commits] [PATCH] D100410: [libc++] Disentangle std::pointer_safety

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

> once P2186 <https://reviews.llvm.org/P2186> lands, remove it from C++ > 20 only. That would maximize the conformance of our implementation

FWIW, I suspect that by the time p2186 lands, we'll be comfortable removing it in all modes; but I agree we don't need to solve that now.
LGTM, ship it!



================
Comment at: libcxx/include/__memory/pointer_safety.h:50
 
+#endif // !C++03
+
----------------
> You'd prefer !defined(_LIBCPP_CXX03_LANG)?
Yes, comparing the incidence of `git grep 'endif.*C++03'` versus `git grep 'endif.*_LIBCPP_CXX03_LANG'`, I think the latter is better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100410/new/

https://reviews.llvm.org/D100410