[libcxx-commits] [PATCH] D100410: [libc++] Disentangle std::pointer_safety

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D100410#2686931 <https://reviews.llvm.org/D100410#2686931>, @Quuxplusone wrote:

> `libcxx/docs/ReleaseNotes.rst` could use some line breaks, and say "scoped enum" rather than "enum class".

Agreed and done.

> The comment `// !C++03` should of course be worded more rigorously.

I don't agree, what's unclear about it? You'd prefer `!defined(_LIBCPP_CXX03_LANG)`?

> P2186 "Removing Garbage Collection Support" <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p2186r0.html> is relevant, and perhaps it would be appropriate to just wait until that paper's landed for C++2b and then rip out the whole thing? If anyone out there would object to wholesale-ripping-GC-out-of-all-modes, IMO it would be useful to bring that up now rather than later.

Hmm, thanks for bringing that paper up. The only question is whether we should rip it out in all standard modes or keep it in C++11/14/17/20 with an empty implementation. I'd be tempted to make the proposed (current) change now to remove tech debt (with no impact on anyone cause nobody cares), and then once P2186 <https://reviews.llvm.org/P2186> lands, remove it from C++ > 20 only. That would maximize the conformance of our implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100410/new/

https://reviews.llvm.org/D100410