[libcxx-commits] [PATCH] D99789: [libc++] Add fallback standard flags and normalize corresponding feature.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Apr 9 08:47:10 PDT 2021


Quuxplusone added a comment.

@ldionne wrote:

> IMO we don't want to allow people to pass --param std=c++2a to Lit. We want to use --param std=c++20

Unfortunately that doesn't scale. Today we //force// people to use `--param std=c++2a` (because this patch hasn't been committed); and we also //force// people to use `--param std=c++2b` (because C++2b hasn't got an official number yet).  We don't want to force everyone to have a "flag day" where they all simultaneously get forced over from `std=c++2a` to `std=c++20`; we want them to be able to adjust their scripts and stuff on their own time. So, since we need to support `std=c++2a` as a synonym for `std=c++20` here anyway at the compiler level, I think it's quite correct to just reuse that list of synonyms for argument parsing as well. Which is what this patch does.

TLDR: This morning I ran `./bin/llvm-lit --param std=c++2a ../libcxx/test/`. I want to run that same command tomorrow morning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99789/new/

https://reviews.llvm.org/D99789



More information about the libcxx-commits mailing list