[libcxx-commits] [PATCH] D99789: [libc++] Add fallback standard flags and normalize corresponding feature.
    Louis Dionne via Phabricator via libcxx-commits 
    libcxx-commits at lists.llvm.org
       
    Fri Apr  9 08:37:29 PDT 2021
    
    
  
ldionne added a comment.
Sorry it took me so long to understand what this patch was doing, however IMO we don't want to allow people to pass `--param std=c++2a` to Lit. We want to use `--param std=c++20`, and then have that query the compiler for either `-std=c++20` or `-std=c++2a` if that's the only thing it supports. I think doing that is simpler, and it leaves the "legacy" `-std=XXX` parameter names to be handled as implementation details of the test suite without making them prominent when using the test suite.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99789/new/
https://reviews.llvm.org/D99789
    
    
More information about the libcxx-commits
mailing list