[libcxx-commits] [PATCH] D99801: [libcxx] adds Microsoft/STL tests for P0898R3

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/test/msvc-stl/README.md:9
+* `test.cpp` files have been renamed to `test.pass.cpp`.
+* LIT directives have been applied to all `test.pass.cpp` files.
+* A single `// clang-format off` has been added to each file underneath LIT directives.
----------------
Mordante wrote:
> What I did in D70631 was a slightly different approach. I kept `test.cpp` and added `test.pass.cpp` The new file consists of:
> ```
> // Copyright block
> 
> // Lit directives
> 
> #include "test.cpp"
> ```
> This change hasn't be reviewed so I don't know whether it's acceptable.
> I choose this approach to the Microsoft files don't contain libc++ lit directives and there would be no need to rename the file.
> 
> WDYT of this approach?
> 
I think that's quite interesting, and yes indeed I think it works. I like that. If we could put all the test files under some subdirectory to make it clear they are not from libc++, I think that's even better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99801/new/

https://reviews.llvm.org/D99801