[libcxx-commits] [PATCH] D99801: [libcxx] adds Microsoft/STL tests for P0898R3

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 6 11:54:11 PDT 2021


ldionne added a comment.

I think this is a great idea, but I also think we need to think about how we're going to handle this in the long term. In particular, I'm a bit wary of updates to these files.

How difficult would it be to write a script that imports those tests from msvc to libc++? This way we could run it periodically and stay up to date? In that spirit, making the smallest number of alterations to the files seems like a must, so I'd welcome using a `.clang-format` at the root of the directory and pretty much anything else that can move us towards that goal.

I don't see any issue w.r.t. licensing since those appear to be licensed under the appropriate license. I don't think it matters who the copyright holder is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99801/new/

https://reviews.llvm.org/D99801



More information about the libcxx-commits mailing list