[libcxx-commits] [PATCH] D99895: [libc++] Implement D2351R0 "Mark all library static cast wrappers as [[nodiscard]]"

Mon Apr 5 14:41:23 PDT 2021

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

In D99895#2669617 <https://reviews.llvm.org/D99895#2669617>, @Quuxplusone wrote:

> @ldionne: Good point. It turns out that there's a dedicated place to hang these new test cases! (Easily found by grepping `libcxx/test/` for "nodiscard", once you'd pointed it out.)
>
> I decided to go ahead and mention `std::bit_cast` in the test file, under a code comment, so that maybe whoever adds `bit_cast` will be grepping for it and find these tests and update them.

Re: `bit_cast`, my implementation was stuck on compiler bugs last time I checked. See D75960 <https://reviews.llvm.org/D75960>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99895/new/

https://reviews.llvm.org/D99895