[libcxx-commits] [PATCH] D99895: [libc++] Implement D2351R0 "Mark all library static cast wrappers as [[nodiscard]]"

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone updated this revision to Diff 335328.
Quuxplusone added a comment.

@ldionne: Good point. It turns out that there's a dedicated place to hang these new test cases! (Easily found by grepping `libcxx/test/` for "nodiscard", once you'd pointed it out.)

I decided to go ahead and mention `std::bit_cast` in the test file, under a code comment, so that maybe whoever adds `bit_cast` will be grepping for it and find these tests and update them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99895/new/

https://reviews.llvm.org/D99895

Files:
  libcxx/docs/UsingLibcxx.rst
  libcxx/include/cstddef
  libcxx/include/functional
  libcxx/include/type_traits
  libcxx/include/utility
  libcxx/test/libcxx/diagnostics/nodiscard_extensions.pass.cpp
  libcxx/test/libcxx/diagnostics/nodiscard_extensions.verify.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99895.335328.patch
Type: text/x-patch
Size: 9957 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210405/3e000ce6/attachment-0001.bin>