[libcxx-commits] [PATCH] D88188: [libc++] Use runtime rather then compile-time glibc version check

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a comment.

In D88188#2301902 <https://reviews.llvm.org/D88188#2301902>, @ldionne wrote:

> I guess I don't really like this sort of mangling of the test suite, however looking at other locale tests, it seems like we already do a lot of it. Furthermore, my lit suggestion would basically allow XFAILing the tests, which isn't what you're after. So I guess this is okay.

Thanks!

> How far back do you support glibc? It would be nice to have a clear bound on this.

2.17 which was shipped with Ubuntu 14.04, this patch is sufficient so I don't think we should need further changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88188/new/

https://reviews.llvm.org/D88188