[libcxx-commits] [PATCH] D88188: [libc++] Use runtime rather then compile-time glibc version check
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Sep 29 14:30:15 PDT 2020
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
I guess I don't really like this sort of mangling of the test suite, however looking at other locale tests, it seems like we already do a lot of it. Furthermore, my lit suggestion would basically allow XFAILing the tests, which isn't what you're after. So I guess this is okay.
How far back do you support glibc? It would be nice to have a clear bound on this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88188/new/
https://reviews.llvm.org/D88188
More information about the libcxx-commits
mailing list