[libcxx-commits] [PATCH] D86748: [libunwind] Bare-metal DWARF: set dso_base to 0

[Ryan Prichard via Phabricator via libcxx-commits]

rprichard added inline comments.


================
Comment at: libunwind/src/UnwindCursor.hpp:84
 public:
+  static const pint_t kSearchAll = static_cast<pint_t>(-1);
   static pint_t findFDE(pint_t mh, pint_t pc);
----------------
compnerd wrote:
> I wonder if we can get away with `constexpr` in addition to `const`.
`constexpr` should work -- libunwind doesn't use it yet, but it uses other C++11 features (e.g. https://reviews.llvm.org/D86411#2233300). I'll switch it from `const` to `constexpr`, which also implies `const` for a variable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86748/new/

https://reviews.llvm.org/D86748