[libcxx-commits] [PATCH] D86748: [libunwind] Bare-metal DWARF: set dso_base to 0

[Saleem Abdulrasool via Phabricator via libcxx-commits]

compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

Yes, sorry I wasn't clear about that, but you understood correctly.  I was suggesting using `-1` as the search all, since it doesn't make sense as a DSO base.  Minor comment about a possible `constexpr` improvement, but doesn't require a re-review.



================
Comment at: libunwind/src/UnwindCursor.hpp:84
 public:
+  static const pint_t kSearchAll = static_cast<pint_t>(-1);
   static pint_t findFDE(pint_t mh, pint_t pc);
----------------
I wonder if we can get away with `constexpr` in addition to `const`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86748/new/

https://reviews.llvm.org/D86748