[libcxx-commits] [PATCH] D87323: Bring atomic header closer to C++20

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Sep 9 04:56:04 PDT 2020


ldionne added inline comments.


================
Comment at: libcxx/test/std/atomics/types.pass.cpp:158
+    test<PaddedTriviallyCopyable>();
+#ifndef __APPLE__
+    test<WeirdTriviallyCopyable>();
----------------
Can you please add a comment here saying `#ifndef __APPLE__ // Apples doesn't ship libatomic` so that we can at least enable that part of the test when/if we ship it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87323/new/

https://reviews.llvm.org/D87323



More information about the libcxx-commits mailing list