[libcxx-commits] [PATCH] D87323: Bring atomic header closer to C++20

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D87323#2262235 <https://reviews.llvm.org/D87323#2262235>, @STL_MSFT wrote:

> @jfb
>
>> It would be good to have an MS person like @STL_MSFT check that the std tests match, at least for what they've implemented.
>
> Unfortunately, we are currently unable to update our llvm-project submodule because a recent change to `lit` broke our test infrastructure - see https://github.com/microsoft/STL/pull/1090 . When we resolve that, we'll be able to run these tests against our `atomic`, but don't block on us. (If we find any issues we'll report back and/or submit a Phab PR and/or skip the affected tests in https://github.com/microsoft/STL/blob/master/tests/libcxx/skipped_tests.txt .)

Hmm, I wasn’t aware of that, but the breakage should have been expected. I’ll help you guys resolve the issue. The intent is to make it a lot easier to run the test suite by other vendors— actually to make such support first class.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87323/new/

https://reviews.llvm.org/D87323