[libcxx-commits] [PATCH] D86055: [libc++] Fix the wrong usage of __STDC_HOSTED__

[hyd-dev via Phabricator via libcxx-commits]

hyd-dev added inline comments.


================
Comment at: libcxx/test/libcxx/libcpp_freestanding.sh.cpp:1
+// -*- C++ -*-
+//===----------------------------------------------------------------------===//
----------------
ldionne wrote:
> Did you run this test? I don't think we can use `FileCheck` in the libcxx tests yet, can we?
> 
> I had a patch lying somewhere that enabled `FileCheck` in the libc++ test suite, but I had shelved it when it became a lot more complicated than expected. Perhaps it's now time to revive it?
> Did you run this test? I don't think we can use FileCheck in the libcxx tests yet, can we?

Sorry, I have run this test before submitting it and it passed, but that was because I installed `FileCheck` using the system package manager.

> I had a patch lying somewhere that enabled FileCheck in the libc++ test suite, but I had shelved it when it became a lot more complicated than expected. Perhaps it's now time to revive it?

That's not necessary. I'll update the test to use `#ifdef`s and `#error`s.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86055/new/

https://reviews.llvm.org/D86055