[libcxx-commits] [PATCH] D86055: [libc++] Fix the wrong usage of __STDC_HOSTED__

Tue Sep 1 07:57:07 PDT 2020

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Thanks for the fix. See my concern about the test, though.

================
Comment at: libcxx/test/libcxx/libcpp_freestanding.sh.cpp:1
+// -*- C++ -*-
+//===----------------------------------------------------------------------===//
----------------
Did you run this test? I don't think we can use `FileCheck` in the libcxx tests yet, can we?

I had a patch lying somewhere that enabled `FileCheck` in the libc++ test suite, but I had shelved it when it became a lot more complicated than expected. Perhaps it's now time to revive it?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86055/new/

https://reviews.llvm.org/D86055