[libcxx-commits] [PATCH] D89674: [libcxx] [test] Fix all remaining issues with fs::path::string_type being wstring

Mon Oct 19 05:43:40 PDT 2020

ldionne added a comment.

In D89674#2338529 <https://reviews.llvm.org/D89674#2338529>, @mstorsjo wrote:

> In D89674#2338516 <https://reviews.llvm.org/D89674#2338516>, @ldionne wrote:
>
>> Accepting as long as you extract `PutEnv` into `filesystem_test_helper.h` and use it everywhere in the test suite!
>
> Sure, that sounds like a good idea, but I'd rather do that in a separate patch (superseding the one you commented on) and keeping this one as such (as a pure path/string handling fix).

Sounds good -- can you open the patch now? I want to make sure we don't accidentally forget to cleanup afterwards :-)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89674/new/

https://reviews.llvm.org/D89674