[libcxx-commits] [PATCH] D89674: [libcxx] [test] Fix all remaining issues with fs::path::string_type being wstring
Martin Storsjö via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Oct 19 05:42:55 PDT 2020
mstorsjo added a comment.
In D89674#2338516 <https://reviews.llvm.org/D89674#2338516>, @ldionne wrote:
> Accepting as long as you extract `PutEnv` into `filesystem_test_helper.h` and use it everywhere in the test suite!
Sure, that sounds like a good idea, but I'd rather do that in a separate patch (superseding the one you commented on) and keeping this one as such (as a pure path/string handling fix).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89674/new/
https://reviews.llvm.org/D89674
More information about the libcxx-commits
mailing list