[libcxx-commits] [PATCH] D89588: [libcxx] [test] Remove a duplicate definition of _CRT_SECURE_NO_WARNINGS

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Oct 16 13:32:34 PDT 2020


mstorsjo added a comment.

In D89588#2335881 <https://reviews.llvm.org/D89588#2335881>, @mstorsjo wrote:

> I'm rerunning the whole testsuite to see if this particular define can be removed from `config.py` as well (there's a fixme comment asking whether it can be removed).

No, removing the define altogether breaks 45 tests that succeeded before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89588/new/

https://reviews.llvm.org/D89588



More information about the libcxx-commits mailing list