[libcxx-commits] [PATCH] D89588: [libcxx] [test] Remove a duplicate definition of _CRT_SECURE_NO_WARNINGS

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D89588#2335828 <https://reviews.llvm.org/D89588#2335828>, @ldionne wrote:

> Instead, do you think it would make sense to only keep this `#define`? I'm trying to remove logic in `config.py`.

The difference is that this header is only included when testing the MS STL, while the defines in `config.py` are added also when testing libc++ itself. These defines are used to silence things in the MSVC C standard library, which would be used (presumably by the test support code) even if testing libc++ itself.

I'm rerunning the whole testsuite to see if this particular define can be removed from `config.py` as well (there's a fixme comment asking whether it can be removed).

For the filesystem stuff, I'd like to add `_CRT_NONSTDC_NO_WARNINGS` similarly, which avoids needing to do anything at all regarding the functions `chdir`, `fileno` and `getcwd` in the support header.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89588/new/

https://reviews.llvm.org/D89588