[libcxx-commits] [PATCH] D89537: [libcxx] [test] Fix string type handling in a few fairly trivial class.path tests

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/test/std/input.output/filesystems/class.path/path.member/path.assign/move.pass.cpp:29
   assert(globalMemCounter.checkOutstandingNewEq(0));
   const std::string s("we really really really really really really really "
                       "really really long string so that we allocate");
----------------
mstorsjo wrote:
> ldionne wrote:
> > Why don't you create `s` directly as `fs::path::string_type`?
> How does one construct a wstring from a non-wide char pointer/literal? Or do you suggest adding a wrapper in some header to wrap the literal, for optionally adding the L prefix?
Ah, you're right. That's why I phrased it as "why don't you" :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89537/new/

https://reviews.llvm.org/D89537