[libcxx-commits] [PATCH] D89537: [libcxx] [test] Fix string type handling in a few fairly trivial class.path tests
Martin Storsjö via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Oct 16 08:40:10 PDT 2020
mstorsjo added inline comments.
================
Comment at: libcxx/test/std/input.output/filesystems/class.path/path.member/path.assign/move.pass.cpp:29
assert(globalMemCounter.checkOutstandingNewEq(0));
const std::string s("we really really really really really really really "
"really really long string so that we allocate");
----------------
ldionne wrote:
> Why don't you create `s` directly as `fs::path::string_type`?
How does one construct a wstring from a non-wide char pointer/literal? Or do you suggest adding a wrapper in some header to wrap the literal, for optionally adding the L prefix?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89537/new/
https://reviews.llvm.org/D89537
More information about the libcxx-commits
mailing list