[libcxx-commits] [PATCH] D89110: [libcxx][dsl] Reduce number of feature checks

[Alexander Richardson via Phabricator via libcxx-commits]

arichardson added a comment.

In D89110#2327483 <https://reviews.llvm.org/D89110#2327483>, @ldionne wrote:

> Thanks a lot for the perf numbers and due diligence.
>
> However, in most contexts, we run the test suite on at least a few tests, where a ~200ms speed up is literally unobservable because the tests are significantly slower than that anyway. I believe this isn't worth the increased complexity. Do you disagree? Do you have a use case where this speed up is observable?

The reason I noticed is that I have a shortcut in setup in my IDE to run a single test so I noticed that the lit startup time was very high. I agree that 200ms is not that much (and doesn't matter at all for the full testsuite), but it is a noticeable delay when running single tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89110/new/

https://reviews.llvm.org/D89110