[libcxx-commits] [PATCH] D89110: [libcxx][dsl] Reduce number of feature checks

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

Thanks a lot for the perf numbers and due diligence.

However, in most contexts, we run the test suite on at least a few tests, where a ~200ms speed up is literally unobservable because the tests are significantly slower than that anyway. I believe this isn't worth the increased complexity. Do you disagree? Do you have a use case where this speed up is observable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89110/new/

https://reviews.llvm.org/D89110