[libcxx-commits] [PATCH] D89003: [libc++] Add caching for feature-detection Lit tests

Fri Oct 9 07:23:17 PDT 2020

ldionne added a comment.

In D89003#2321042 <https://reviews.llvm.org/D89003#2321042>, @arichardson wrote:

> Thanks, this is much better than my specialized version. However, I don't think it's correct since you are passing a reference to a mutable object to the cache so c.substitutions it will always be equal.
> I just tested this and the cache will still hit if we append a value to config.substitutions between checks.

Excellent catch! I fixed it in ddb2baf9fbff3d574c6c2bd69c2c9569100509a4 <https://reviews.llvm.org/rGddb2baf9fbff3d574c6c2bd69c2c9569100509a4>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89003/new/

https://reviews.llvm.org/D89003