[libcxx-commits] [PATCH] D89003: [libc++] Add caching for feature-detection Lit tests

[Alexander Richardson via Phabricator via libcxx-commits]

arichardson added a comment.

Thanks, this is much better than my specialized version. However, I don't think it's correct since you are passing a reference to a mutable object to the cache so c.substitutions it will always be equal.
I just tested this and the cache will still hit if we append a value to config.substitutions between checks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89003/new/

https://reviews.llvm.org/D89003