[libcxx-commits] [PATCH] D88884: [libc++][dsl] Run checks for locale names aliases using a single %exec

Alexander Richardson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Oct 9 01:11:01 PDT 2020


arichardson added inline comments.


================
Comment at: libcxx/utils/libcxx/test/dsl.py:138
 
-def hasLocale(config, locale):
+def hasLocale(config, locale, names):
   """
----------------
ldionne wrote:
> Could we simply change this to `hasAnyLocale(config, locales)`, and then you pass a list of all the `alts` below?
Yes definitely, I only had the name included for debugging and didn't remove it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88884/new/

https://reviews.llvm.org/D88884



More information about the libcxx-commits mailing list