[libcxx-commits] [PATCH] D88884: [libc++][dsl] Run checks for locale names aliases using a single %exec

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Generally looks good to me, with suggestion. I agree it's more clever to check things this way.



================
Comment at: libcxx/utils/libcxx/test/dsl.py:138
 
-def hasLocale(config, locale):
+def hasLocale(config, locale, names):
   """
----------------
Could we simply change this to `hasAnyLocale(config, locales)`, and then you pass a list of all the `alts` below?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88884/new/

https://reviews.llvm.org/D88884