[libcxx-commits] [PATCH] D92212: Make libcxx work according to Clang C++ Status if -fchar8_t is passed

Yuriy Chernyshov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 30 11:19:54 PST 2020


georgthegreat added a comment.

1. My thoughts are quite different. This macro requires double negation upon usage: `#ifndef _LIBCPP_NO_HAS_CHAR8_T`. I personally find troubles reading any negation. `#ifdef __cpp_char8_t` is much shorter and easier to understand. And it is standartized!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92212/new/

https://reviews.llvm.org/D92212



More information about the libcxx-commits mailing list