[libcxx-commits] [PATCH] D92212: Make libcxx work according to Clang C++ Status if -fchar8_t is passed

Mon Nov 30 10:04:10 PST 2020

mclow.lists added inline comments.

================
Comment at: libcxx/include/__config:956
 #define _LIBCPP_NO_HAS_CHAR8_T
 #endif
 // Deprecation macros.
----------------
miscco wrote:
> mclow.lists wrote:
> > georgthegreat wrote:
> > > As of this PR, _LIBCPP_NO_HAS_CHAR8_T became a simple negation of __cpp_char8_t.
> > > 
> > > The configuration might become easier to read upon replacing all invocation of these options with feature testing macro.
> > I'm a big fan of keeping the libc++-specific macro.  
> Could you name a benefit that vendor specific macros have over the universal ones?
Yes.

1) It's more readable. 
2) Until this patch, it was different from `__cpp_char8_t`. It may need to be so again in the future.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92212/new/

https://reviews.llvm.org/D92212