[libcxx-commits] [PATCH] D90569: [RFC] [libc++] P1645 constexpr for <numeric>

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp:39
+    // don't have the support yet. In these cases use a std::span for the test.
+	size_t size = std::distance(first, last);
+#if TEST_STD_VER < 20 || \
----------------
LGTM, but could you add a FIXME to remind us to go back and fix those once constexpr `std::vector` is finished?

If you keep the FIXME exactly the same in all places where you use this pattern, we'll be able to search for it and easily replace all locations where we used the workaround.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90569/new/

https://reviews.llvm.org/D90569