[libcxx-commits] [PATCH] D90569: [RFC] [libc++] P1645 constexpr for <numeric>

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D90569#2385641 <https://reviews.llvm.org/D90569#2385641>, @ldionne wrote:

> In D90569#2371916 <https://reviews.llvm.org/D90569#2371916>, @Mordante wrote:
>
>> Is there a reason why their signatures differ or is it an oversight?
>> Shall I fix them in this patch?
>
> I believe those are oversights, and the blame seems to confirm this. Good catch, and please fix them in this patch. You don't need `inline` though, just `_LIBCPP_INLINE_VISIBILITY`. These functions are already `inline` (i.e. linkonce-ODR) because they are templates.

Thanks will do.

> On a different note, I would like to mention that I really like your approach of making sure everything's fine with a single function, and then going for the whole thing. I feel like this is a productive way to proceed, and I appreciate that.

Thanks. I also prefer this way since it saves everybody time!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90569/new/

https://reviews.llvm.org/D90569