[libcxx-commits] [PATCH] D63059: Implements multiline regex support

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added a comment.

Thanks for the review!

In D63059#2400880 <https://reviews.llvm.org/D63059#2400880>, @ldionne wrote:

> LGTM, thanks a lot for this! Consider my comment about the comments you left behind, but feel free to commit without implementing my suggestion.

I'll remove them.

> I don't understand why CI isn't running -- it seems to be doing that with a few patches. If you commit this, can you please keep an eye on https://buildkite.com/llvm-project/libcxx-ci/builds?branch=master for the next build?

I'll keep an eye on the build bot.
I update the patches in the review using Phabricator's web-interface. Can the fact that I don't use arc be the reason the CI builds aren't triggered?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63059/new/

https://reviews.llvm.org/D63059