[libcxx-commits] [PATCH] D63059: Implements multiline regex support

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.

LGTM, thanks a lot for this! Consider my comment about the comments you left behind, but feel free to commit without implementing my suggestion.

I don't understand why CI isn't running -- it seems to be doing that with a few patches. If you commit this, can you please keep an eye on https://buildkite.com/llvm-project/libcxx-ci/builds?branch=master for the next build?



================
Comment at: libcxx/include/regex:1995
+
+// LWG-2503 Added the multiline flag. In order to avoid an ABI break the
+// __l_anchor has not been modified, it has been replaced with a new class.
----------------
I don't think this comment is relevant, since `__l_anchor` doesn't exist anymore. I feel like questions of this nature can be answered best via `git blame` and following the link back to this review. If you feel strongly that it adds value, please feel free to leave it in.


================
Comment at: libcxx/include/regex:2041
 
+// LWG-2503 Added the multiline flag. In order to avoid an ABI break the
+// __r_anchor has not been modified, it has been replaced with a new class.
----------------
Ditto.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63059/new/

https://reviews.llvm.org/D63059