[libcxx-commits] [PATCH] D91413: [libcxx] Provide __int128_t builtins needed for filesystem on MSVC

[Nico Weber via Phabricator via libcxx-commits]

thakis added a comment.

Hrm, this seems like a fix at the wrong layer to me.

Since __int128_t creates compiler_rt calls, it'd seem reasonable if we made __uint128_t error out when targeting windows in the compiler, or if we changed codegen to call _mul128() on windows, or some such. This change here would mean that making such a change in clang would break libcxx, which seems a bit unfortunate.

Maybe we should just teach clang to use _mul128() when targeting windows?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91413/new/

https://reviews.llvm.org/D91413