[libcxx-commits] [PATCH] D91413: [libcxx] Provide __int128_t builtins needed for filesystem on MSVC

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo added reviewers: libc++, amccarth, thakis.
Herald added a subscriber: mgorny.
Herald added a project: libc++.
Herald added 1 blocking reviewer(s): libc++.
mstorsjo requested review of this revision.

When building with clang-cl targeting MSVC, the __int128_t type is available, but the runtime helpers (normally provided by libgcc or compiler_rt builtins) aren't available; bundle them within libc++ in those cases. (The same is already done for one function that is missing in libgcc but present in compiler_rt.)

This is an alternative to D91139 <https://reviews.llvm.org/D91139> (which just disables the use of __int128_t for MSVC targets). Either of these has to be picked before settling down the ABI of libc++ filesystem on MSVC targets. This one on the other hand hardcodes the clang-specific __int128_t into the ABI for MSVC targets.

(For MinGW targets, none of this is an issue as libgcc and/or compiler_rt are available.)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D91413

Files:
  libcxx/src/CMakeLists.txt
  libcxx/src/filesystem/int128_builtins_msvc.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91413.305098.patch
Type: text/x-patch
Size: 7297 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201113/17cdbd3d/attachment-0001.bin>