[libcxx-commits] [PATCH] D90601: [libcxx] Avoid double frees of file descriptors in the fallback ifstream/ofstream codepath

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D90601#2369985 <https://reviews.llvm.org/D90601#2369985>, @ldionne wrote:

> Do I understand this is triggered by the test suite when we build the dylib with `_LIBCPP_FILESYSTEM_USE_FSTREAM`, and so this doesn't need a test added?

Indeed, it's triggered by some of the fs.op.copy* tests, but whether the C runtime errors out on it (and how loudly) varies I guess. Afaik most of the actual deployments of libc++ std::fs so far has been using the copyfile/sendfile implementations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90601/new/

https://reviews.llvm.org/D90601