[libcxx-commits] [PATCH] D90601: [libcxx] Avoid double frees of file descriptors in the fallback ifstream/ofstream codepath
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Nov 2 15:57:32 PST 2020
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
Do I understand this is triggered by the test suite when we build the dylib with `_LIBCPP_FILESYSTEM_USE_FSTREAM`, and so this doesn't need a test added?
If so, LGTM, otherwise please add a test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90601/new/
https://reviews.llvm.org/D90601
More information about the libcxx-commits
mailing list