[libcxx-commits] [PATCH] D90476: [libcxxabi] Build all of libcxxabi with _LIBCPP_BUILDING_LIBRARY defined

[Shoaib Meenai via Phabricator via libcxx-commits]

smeenai added a comment.

In D90476#2367494 <https://reviews.llvm.org/D90476#2367494>, @compnerd wrote:

> This is definitely a good cleanup IMO.  I wonder if this should be taken a step further and use the "standard" (well, as far as CMake is concerned) standard macros of `LIBCXX_EXPORTS`.  Of course, that is probably done better in a subsequent change.

IIRC, we used to rely on this at some point, and then libc++ changed to use a common object library for both the static and shared libraries, at which point you couldn't rely on CMake to define that. I think we we build the static and shared libraries as separate libraries again rather than using the object library (to get PIC right), so the default export macro should be available to us again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90476/new/

https://reviews.llvm.org/D90476