[libcxx-commits] [PATCH] D90476: [libcxxabi] Build all of libcxxabi with _LIBCPP_BUILDING_LIBRARY defined

Saleem Abdulrasool via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Nov 1 21:20:16 PST 2020


compnerd added a comment.

This is definitely a good cleanup IMO.  I wonder if this should be taken a step further and use the "standard" (well, as far as CMake is concerned) standard macros of `LIBCXX_EXPORTS`.  Of course, that is probably done better in a subsequent change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90476/new/

https://reviews.llvm.org/D90476



More information about the libcxx-commits mailing list