[libcxx-commits] [PATCH] D76731: [libc++] Do not rely on the environment to run filesystem tests

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF accepted this revision.
EricWF added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/test/support/filesystem_test_helper.h:232
 
-    fs::path const test_root;
 
----------------
ldionne wrote:
> EricWF wrote:
> > Why did you drop the const?
> Because of `test_root = fs::canonical(test_root);` above in the constructor. Note that I can't set that in the initializer list, because `fs::canonical` requires the `test_root` to exist, which is set up in the constructor body.
Alright. I'm OK with this.

I would rather it be const, but *shrug*.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76731/new/

https://reviews.llvm.org/D76731