[libcxx-commits] [PATCH] D76731: [libc++] Do not rely on the environment to run filesystem tests
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Mar 26 08:38:53 PDT 2020
ldionne marked 2 inline comments as done.
ldionne added inline comments.
Comment at: libcxx/test/support/filesystem_test_helper.h:232
- fs::path const test_root;
> Why did you drop the const?
Because of `test_root = fs::canonical(test_root);` above in the constructor. Note that I can't set that in the initializer list, because `fs::canonical` requires the `test_root` to exist, which is set up in the constructor body.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits