[libcxx-commits] [PATCH] D76731: [libc++] Do not rely on the environment to run filesystem tests

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked 2 inline comments as done.
ldionne added inline comments.


================
Comment at: libcxx/test/support/filesystem_test_helper.h:232
 
-    fs::path const test_root;
 
----------------
EricWF wrote:
> Why did you drop the const?
Because of `test_root = fs::canonical(test_root);` above in the constructor. Note that I can't set that in the initializer list, because `fs::canonical` requires the `test_root` to exist, which is set up in the constructor body.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76731/new/

https://reviews.llvm.org/D76731