[libcxx-commits] [PATCH] D66610: [libc++] ECMAScript IdentityEscape is ambiguous (2584)

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Mar 14 13:25:15 PDT 2020

zoecarver added a comment.

@ldionne thanks for the review! Sorry for the delayed response/update. Last week I was super busy with another project I work on.

Comment at: libcxx/test/std/re/re.alg/re.alg.match/ecma.pass.cpp:1401
+        // const std::regex r3("\\zz");
+        // assert(std::regex_match("zzz", r3));
ldionne wrote:
> Why are those tests commented out?
I wasn't sure if they should also work (they currently don't because, while the first part is matched, it fails when it sees the extra `z`). Looking at it again I think that's the correct behavior (not to match). 

I'm going to remove it from this patch. If it is supposed to work, I think that's a different issue than the one addressed here.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list