[libcxx-commits] [PATCH] D66610: [libc++] ECMAScript IdentityEscape is ambiguous (2584)

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/test/std/re/re.alg/re.alg.match/ecma.pass.cpp:1394
     }
+    {   // Issue2584: identify escape. Match exact chars/strings.
+        const std::regex r1("\\z");
----------------
Use LWG#2584 to make it clear it's a LWG issue


================
Comment at: libcxx/test/std/re/re.alg/re.alg.match/ecma.pass.cpp:1394
     }
+    {   // Issue2584: identify escape. Match exact chars/strings.
+        const std::regex r1("\\z");
----------------
ldionne wrote:
> Use LWG#2584 to make it clear it's a LWG issue
Also, this should be `identity escapes` instead of `identify escape`.


================
Comment at: libcxx/test/std/re/re.alg/re.alg.match/ecma.pass.cpp:1401
+
+        // const std::regex r3("\\zz");
+        // assert(std::regex_match("zzz", r3));
----------------
Why are those tests commented out?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66610/new/

https://reviews.llvm.org/D66610