[libcxx-commits] [PATCH] D76093: Don't expose unavailable cstdio functions.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.
Herald added a subscriber: dexonsmith.


================
Comment at: libcxx/include/__config:1550
+// using 64-bit file offsets on LP32.
+#if !defined(__ANDROID__) || !defined(__USE_FILE_OFFSET64) ||                  \
+    (__ANDROID_API__ >= 24)
----------------
I believe this would be easier to understand if it were instead `_LIBCPP_HAS_NO_FGETPOS`. The condition would become:

```
#if defined(__ANDROID__) && defined(__USE_FILE_OFFSET64) && __ANDROID_API < 24
```

Do you agree?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76093/new/

https://reviews.llvm.org/D76093